Skip to content

refactor(sketch): use raygeo's parameter context - #739

Draft
knipknap wants to merge 1 commit into
refactor/sketch-registry-raygeofrom
refactor/sketch-params-raygeo
Draft

knipknap wants to merge 1 commit into
refactor/sketch-registry-raygeofrom
refactor/sketch-params-raygeo

Conversation

@knipknap

Copy link
Copy Markdown
Contributor

Switches the sketch document to raygeo.sketch.params.ParameterContext.

What changed:

  • deletes sketcher/core/params.py
  • updates production and test imports to the Rust binding
  • keeps numeric parameters, text input parameters, expressions, and .ryp {'expressions': {...}} serialization
  • replaces Python logging assertions with the Rust context's unresolved_errors() diagnostics
  • no Python parameter shim remains

Stacked on #734 and barebaric/raygeo#141.

Verified against the raygeo branch:

  • full rayforge backend suite -> 7748 passed, 1 skipped
  • pixi run lint -> 0 pyright errors

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant